[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH RFC v1 09/14] Makefile: delete STUBDOMPATH target

On Thu, Mar 31, 2016 at 10:21:22AM +0000, Xu, Quan wrote:
> On March 11, 2016 12:53am, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
> > -build: $(STUBDOMPATH)
> > +build: $(STUBDOM_BUILD)
> Wei,
> in original code, in stubdom/vtpm and stubdom/vtpmmgr, the code style is 
> inconsistent and ugly.
> Do you have any plan to fix them? :)

No, I don't.

> btw, if the others(or me) want to fix the code style, how to fix it? send out 
> a big patch? Any suggestions?
> Thanks.:)

I personally prefer small patches in a series, but I don't object to
having large patch(es) either. At the end of the day, I think Daniel's
opinion matters most. After a plan is agreed upon, you can then provide
a branch for us to pull in. Note that upstream don't test vtpm in any
fashion so you do need to run your tests.

The only thing that matters to me is that when you will do it -- you
will need to patch a different tree after I split off stubdom. In order
to minimise the fuss one of us will need to wait for the other.


> Quan

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.