[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 1/8] blkif: document how FreeBSD uses the physical-device backend node



On Thu, Mar 31, 2016 at 4:09 PM, Roger Pau Monne <roger.pau@xxxxxxxxxx> wrote:
> FreeBSD blkback uses the physical-device-path xenstore node in order to
> fetch the path to the underlying backing storage (either a block device or
> raw image). This node is set by the hotplug scripts. Also clarify the usage
> of the physical-device node.
>
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Looks good to me:

Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxx>

> ---
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Jan Beulich <jbeulich@xxxxxxxx>
> Cc: Tim Deegan <tim@xxxxxxx>
> ---
> Changes since v2:
>  - Use physical-device-path instead of physical-device in order to store the
>    absolute path to the backing disk image.
> ---
>  xen/include/public/io/blkif.h | 13 +++++++++++--
>  1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/xen/include/public/io/blkif.h b/xen/include/public/io/blkif.h
> index 99f0326..ce0dbfe 100644
> --- a/xen/include/public/io/blkif.h
> +++ b/xen/include/public/io/blkif.h
> @@ -89,15 +89,23 @@
>   *      Values:         string
>   *
>   *      A free formatted string providing sufficient information for the
> - *      backend driver to open the backing device.  (e.g. the path to the
> - *      file or block device representing the backing store.)
> + *      hotplug script to attach the device and provide a suitable
> + *      handler (ie: a block device) for blkback to use.
>   *
>   * physical-device
>   *      Values:         "MAJOR:MINOR"
> + *      Notes: 11
>   *
>   *      MAJOR and MINOR are the major number and minor number of the
>   *      backing device respectively.
>   *
> + * physical-device-path
> + *      Values:         path string
> + *
> + *      A string that contains the absolute path to the disk image. On
> + *      NetBSD and Linux this is always a block device, while on FreeBSD
> + *      it can be either a block device or a regular file.
> + *
>   * type
>   *      Values:         "file", "phy", "tap"
>   *
> @@ -391,6 +399,7 @@
>   *     than RING_SIZE * BLKIF_MAX_SEGMENTS_PER_REQUEST.
>   *(10) The discard-secure property may be present and will be set to 1 if the
>   *     backing device supports secure discard.
> + *(11) Only used by Linux and NetBSD.
>   */
>
>  /*
> --
> 2.6.4 (Apple Git-63)
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.