Re: [Xen-devel] [PATCH v8 for Xen 4.7 4/4] xl: enable per-VCPU parameter for RTDS

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On Thu, 2016-03-31 at 18:00 +0100, Wei Liu wrote:
> On Fri, Mar 18, 2016 at 04:26:25PM -0500, Chong Li wrote:
> > 
> > Change main_sched_rtds and related output functions to support
> > per-VCPU settings.
> > 
> > Signed-off-by: Chong Li <chong.li@xxxxxxxxx>
> > Signed-off-by: Meng Xu <mengxu@xxxxxxxxxxxxx>
> > Signed-off-by: Sisu Xi <xisisu@xxxxxxxxx>
> > 
> > ---
> > Changes on PATCH v7:
> > 1) Add example to xl.pod.1
> > 
> So you've added what I asked. I'm satisfied with this patch.
> 
> Subject to ack or review by Dario:
> 
>   Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> 
Here I am. I had a look (and sorry if it took a bit), and I indeed
found what I believe are a few issues.

The re-wording of the examples in the manual page are improvements IMO
(although I'm not a native speaker myself), but, much more important,
I've seen things in the code that I think need changing.

Nothing too complicated to do, I think, but still something.

So, Wei, perhaps you can give a quick look at my comments and say
whether you think my observations make any sense? If they do, and if
Chong respins the series, I guarantee I'll be much quicker in re-
reviewing it. :-)

Thanks and Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel