[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 6/6] xentrace: ARM platform timestamp support

On Thu, 31 Mar 2016, Ben Sanda wrote:
> Stefano,
> Thank you for the comments. In response:
> > Changing cycles_t to uint64_t sounds good, but why did you move
> > boot_count here from below?
> I had to move it up so it would be defined for use in the updated
> get_cycles() call: 
> return READ_SYSREG64(CNTPCT_EL0) - boot_count;
> Should get_cyclces not use boot_count? I included it as the normal
> system time call uses it so I assumed this should be consistent.

Sorry I misread your patch. Your implementation of get_cycles is
correct but I would prefer to avoid including asm/regs.h in time.h.

I would prefer if the implementation was in xen/arch/arm/time.c (even if
that means no static inline). Then you could base get_s_time on get_cycles.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.