[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 06/10] xl_cmdimpl: improve return codes for cd-insert commands

On Fri, 1 Apr 2016, Paulina Szubarczyk wrote:

>  - Use EXIT_{SUCCESS,FAILURE} for main_cd*() function
>  - Use 0/1 as return values of cd_insert function
> Signed-off-by: Paulina Szubarczyk <paulinaszubarczyk@xxxxxxxxx>

LGTM, although I would prefer that the return value of cd_insert is stored 
in a local variable and then checked. I don't think this should block the 
patch, since it's an improvement overall:

Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.