Re: [Xen-devel] [PATCH v6 3/6] libxl: add query function for backend support by device model

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Apr 01, 2016 at 03:23:03PM +0100, Anthony PERARD wrote:
> On Thu, Mar 31, 2016 at 03:33:59PM +0100, Wei Liu wrote:
> > On Thu, Mar 31, 2016 at 07:49:03AM +0200, Juergen Gross wrote:
> > > Add a function to query whether the device model is supporting a
> > > specific backend type. The device model is writing the supported
> > > backend types to Xenstore on startup. The new query function checks
> > > for the appropriate entry to be present.
> > > 
> > > As not all versions of qemu are capable to indicate support of
> > > specific backends the query function is to be called with an indicator
> > > whether the default return value should be "supported" (in case qemu
> > > doesn't know set any support information) or "not supported".
> > > 
> > > Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> > > ---
> > > V6: add Xenstore path documentation as requested by Wei Liu
> > > ---
> > >  docs/misc/xenstore-paths.markdown |  7 +++++++
> > >  tools/libxl/libxl_dm.c            | 19 +++++++++++++++++++
> > >  tools/libxl/libxl_internal.h      |  5 +++++
> > >  3 files changed, 31 insertions(+)
> > > 
> > > diff --git a/docs/misc/xenstore-paths.markdown 
> > > b/docs/misc/xenstore-paths.markdown
> > > index 76f67b1..890d261 100644
> > > --- a/docs/misc/xenstore-paths.markdown
> > > +++ b/docs/misc/xenstore-paths.markdown
> > > @@ -472,6 +472,13 @@ in the value supplied by the guest in this case).
> > >  
> > >  Contains the status of the device models running on the domain.
> > >  
> > > +#### ~/device-model/$DOMID/backends/* [w]
> > > +
> > > +Backend types the device model is supporting. Each entry below backends
> > > +is a directory which may contain further nodes specific to the backend
> > > +type. The name of each backend directory is the same as the backend type
> > > +(e.g. "qdisk").
> > > +
> > 
> > Anthony, can you ack / nack this?
> 
> That sounds good to me.
> Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Thanks, in that case:

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

> 
> > The rest of code looks OK.
> > 
> > Wei.
> 
> -- 
> Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel