Re: [Xen-devel] [PATCH v10 4/5] libxl: add support for vscsi

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Olaf Hering writes ("Re: [PATCH v10 4/5] libxl: add support for vscsi"):
> On Fri, Apr 01, Ian Jackson wrote:
> > I'm not sure that this sysfs parsing ought to be in xl rather than
> > libxl.  Also, this is Linux-specific code.  So it needs to be made
> > conditional somehow.
> 
> The whole libxlu file is inside #ifdef __linux__?

Oh, so it is.  Sorry for not spotting that.  TBH I think it might be
better to do this the way that other kernel-specific things are done,
eg libxl_linux.c etc.

But I think changing this ought to wait until we settle whether this
code ought to be in xl or libxl.

> I will address the other comments in another mail.

Thanks
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel