Re: [Xen-devel] [PATCH v2 5/6] x86/time: refactor read_platform_stime()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 05.04.16 at 17:22, <joao.m.martins@xxxxxxxxxx> wrote:
> On 04/05/2016 12:52 PM, Jan Beulich wrote:
>>>>> On 29.03.16 at 15:44, <joao.m.martins@xxxxxxxxxx> wrote:
>>> -static s_time_t read_platform_stime(void)
>>> +static s_time_t read_platform_stime(u64 *stamp)
>>>  {
>>> -    u64 count;
>>> +    u64 plt_stamp_counter, count;
>> 
>> "stamp" and "counter" seem kind of redundant.
>> 
> A bit, perhaps you prefer the latter? There was a variable named "count", so I
> named "stamp" for clearer distinction between the variables and the output 
> arg.

Between plt_stamp and plt_counter I'd indeed have a slight preference
towards the latter.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel