Re: [Xen-devel] [PATCH v4 12/26] x86/cpu: Move set_cpumask() calls into c_early_init()

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 28/03/16 16:55, Konrad Rzeszutek Wilk wrote:
> On Wed, Mar 23, 2016 at 04:36:15PM +0000, Andrew Cooper wrote:
>> Before c/s 44e24f8567 "x86: don't call generic_identify() redundantly", the
>> commandline-provided masks would take effect in Xen's view of the features.
> s/the// ?
>
> Or perhaps s/the/cpuid// ?

"the processor features"? 

>> As the masks got applied after the query for features, the redundant call to
>> generic_identify() would clobber the pre-masking feature information with the
>> post-masking information.
>>
>> Move the set_cpumask() calls into c_early_init() so their effects take place
> s/their effects take/it's effect takes/ 

"their" is supposed to be referring to the cpuid mask command line
parameters, but I will see if I can reword.

>
>> before the main query for features in generic_identify().
> .. and unifying all c_early_init() functions behavior?

I don't understand what you are trying to get at here.  I am moving the
masking setup from c_init() to c_early_init() for both Intel and AMD.  I
don't see what I am supposedly unifying.

>
>> The cpuid_mask_* command line parameters now limit the entire system, a
>> feature XenServer was relying on for testing purposes.  Subsequent changes
> .. what are those changes? Could you mention the title of the patch perhaps?

Specifically, the complete combination of patches 14 through 18, but as
this part of the series can't reasonably be committed piecemeal, there
is no risk of other changes getting inbetween.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel