Re: [Xen-devel] [PATCH 0/3] COLO: only build on Linux

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Apr 06, 2016 at 06:20:52PM +0800, Wen Congyang wrote:
> On 04/06/2016 06:17 PM, Wei Liu wrote:
> > On Wed, Apr 06, 2016 at 09:24:26AM +0800, Wen Congyang wrote:
> >> On 04/06/2016 04:05 AM, Wei Liu wrote:
> >>> COLO depends on netlink which is only available on Linux. This series 
> >>> cleans up
> >>> COLO code and make it only build on Linux. This should fix FreeBSD build.
> >>>
> >>> Congyang and Changlong, please review this series as soon as possible. I 
> >>> also
> >>> have a question why COLO doesn't use libnl? It is using Linux header 
> >>> directly.
> >>
> >> It is implemented by Yang one year ago. I don't know the reason. We will 
> >> investigate
> >> how to use libnl.
> >>
> > 
> > It's easy -- change inclusion of linux/netlink.h to netlink/netlink.h. I
> > already have a series to do that -- this series is actually my second
> > attempt to fix COLO.
> > 
> > If you can confirm COLO should depend on libnl, I will post my patches.
> 
> I think COLO should depend on libnl.
> 

NP, patch series incoming.

Wei.

> Thanks
> Wen Congyang
> 
> > 
> > Wei.
> > 
> >> Thanks
> >> Wen Congyang
> >>
> >>>
> >>> Roger, can you run functional tests on FreeBSD? I don't have FreeBSD Dom0.
> >>>
> >>> Wei.
> >>>
> >>> Wei Liu (3):
> >>>   libxl: colo: rearrange things in header files
> >>>   libxl: colo: move netlink related stuff to libxl_colo_proxy.c
> >>>   libxl: colo: only build COLO on Linux
> >>>
> >>>  tools/libxl/Makefile           |  5 ++++
> >>>  tools/libxl/libxl_colo.h       | 52 +++++++++++++++++------------------
> >>>  tools/libxl/libxl_colo_proxy.c | 13 +++++++++
> >>>  tools/libxl/libxl_internal.h   | 36 ++++++++----------------
> >>>  tools/libxl/libxl_no_colo.c    | 62 
> >>> ++++++++++++++++++++++++++++++++++++++++++
> >>>  5 files changed, 117 insertions(+), 51 deletions(-)
> >>>  create mode 100644 tools/libxl/libxl_no_colo.c
> >>>
> >>
> >>
> >>
> > 
> > 
> > .
> > 
> 
> 
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel