Re: [Xen-devel] [PATCH v5 15/21] tools/libxc: Modify bitmap operations to take void pointers

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Apr 07, 2016 at 12:57:20PM +0100, Andrew Cooper wrote:
> The type of the pointer to a bitmap is not interesting; it does not affect the
> representation of the block of bits being pointed to.
> 
> Make the libxc functions consistent with those in Xen, so they can work just
> as well with 'unsigned int *' based bitmaps.
> 
> As part of doing so, change the implementation to be in terms of char rather
> than unsigned long.  This fixes alignment concerns with ARM.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

The code looks fine to me.

We've given enough time for ARM folks to object so:

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

We can always fix this on ARM if it appears to be broken.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel