Re: [Xen-devel] [PATCH v4 08/14] hvmloader: Locate the BIOS blob

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 07.04.16 at 17:10, <anthony.perard@xxxxxxxxxx> wrote:
> On Tue, Apr 05, 2016 at 06:59:03AM -0600, Jan Beulich wrote:
>> >>> On 14.03.16 at 18:55, <anthony.perard@xxxxxxxxxx> wrote:
>> > --- a/tools/firmware/hvmloader/hvmloader.c
>> > +++ b/tools/firmware/hvmloader/hvmloader.c
>> > @@ -292,8 +322,16 @@ int main(void)
>> >      }
>> >  
>> >      printf("Loading %s ...\n", bios->name);
>> > -    if ( bios->bios_load )
>> > -        bios->bios_load(bios);
>> > +    bios_module = get_module_entry(hvm_start_info, "bios");
>> 
>> Isn't "bios" a bit vague, as there could be multiple (system, video,
>> add-on card)?
> 
> Maybe a bit, also this can be use to load OVMF which is not technically a
> BIOS. I guess a better name would be "firmware" or "system firmware".
> 
> On the other hand, the name "bios" is used in few places, in hvmloader, in
> libxl (to choose between seabios/ovmf).

Perhaps that's a result of how that code evolved? I'm not heavily
objecting to using "bios" here, but I think this being a newly
introduced name it could as well be made more correct.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel