Re: [Xen-devel] [PATCH for-4.7 v2 2/2] xen/x86: Introduce a new VMASSIST for architectural behaviour of iopl

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 07.04.16 at 23:39, <andrew.cooper3@xxxxxxxxxx> wrote:
> @@ -1763,7 +1765,8 @@ static void load_segments(struct vcpu *n)
>                  vcpu_info(n, evtchn_upcall_mask) = 1;
>  
>              regs->entry_vector |= TRAP_syscall;
> -            regs->_eflags      &= 0xFFFCBEFFUL;
> +            regs->_eflags      &= 
> ~(X86_EFLAGS_AC|X86_EFLAGS_VM|X86_EFLAGS_RF|
> +                                    
> X86_EFLAGS_NT|X86_EFLAGS_IOPL|X86_EFLAGS_TF);

Why AC, which didn't get cleared before? Did you just copy
the 64-bit variant from below? Assuming so, with it removed
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel