[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 05/10] xl_cmdimpl: improve return codes for memset commands

On Wed, 2016-04-06 at 13:45 +0200, Paulina Szubarczyk wrote:
> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c
> @@ -3391,15 +3391,15 @@ static int set_memory_max(uint32_t domid,
> const char *mem)
>      memorykb = parse_mem_size_kb(mem);
>      if (memorykb == -1) {
>          fprintf(stderr, "invalid memory size: %s\n", mem);
> -        exit(3);
> +        return 1;
Mmmm.. I see no reason why this can't remain exit(). In fact, it should
be turned int exit(EXIT_FAILURE), and there's Harmandeep's series --
just resubmitted by me tonight-- outstanding that does that [1].

In any case, this patch is probably not necessary any longer, not
because Harmandeep pending series, but because George take care of what
I think you're trying to do in here in
commit 0614c454209ac67016e2296577abfee9e9dcb012 already.


[1] http://lists.xenproject.org/archives/html/xen-devel/2016-04/msg01099.html
<<This happens because I choose it to happen!>> (Raistlin Majere)
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.