Re: [Xen-devel] [PATCH v11 1/2] libxl: add support for vscsi

[Olaf Hering <olaf@xxxxxxxxx>]

On Fri, Apr 08, Olaf Hering wrote:

> +int xlu_vscsi_get_ctrl(XLU_Config *cfg, libxl_ctx *ctx, uint32_t domid,
> +                       const char *str,
> +                       libxl_device_vscsictrl *ctrl,
> +                       libxl_device_vscsidev *dev,
> +                       libxl_device_vscsictrl **existing)

> +    if (found_ctrl == -1) {
> +        *existing = NULL;

> +int main_vscsiattach(int argc, char **argv)

> +    libxl_device_vscsictrl ctrl, *existing = NULL;

> +    existing = xmalloc(sizeof(*existing));
> +    libxl_device_vscsictrl_init(existing);

This handling of 'existing' is bogus, I will rework it. Not sure what I
had in mind here...

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel