Re: [Xen-devel] [PATCH v2] libxl: replace the usage of uuid_t with a char array

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Thu, 7 Apr 2016, Ian Jackson wrote:
> Wei Liu writes ("Re: [PATCH v2] libxl: replace the usage of uuid_t with a 
> char array"):
> > A thought: maybe it is worth to have a #define LIBXL_HAVE_UNIFIED_UUID
> > in libxl.h?
> 
> This is a good idea.
> 
> > /* If this is defined, libxl_uuid is big endian 16-octet stream on all
> >  * platform. The libxl_uuid API family will handle transformation
> >  * between libxl_uuid format and OS specific format.
> >  */
> > #define LBIXL_HAVE_UNIFIED_UUID 1
> 
> But the wording here isn't, quite.  The "transformation between
> libxl_uuid format and OS specific format" is entirely hidden within
> libxl and exists only to implement the functions provided by libxl.

What about:

/*
 * LIBXL_HAVE_BYTEARRAY_UUID
 *
 * If this is defined, the internal member of libxl_uuid is defined
 * as a 16 byte array that contains the UUID in big endian format.
 * Also, the same structure layout is used across all OSes.
 */
#define LIBXL_HAVE_BYTEARRAY_UUID 1

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel