[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/4] libxl: set the device model version earlier in xenstore

On Fri, 8 Apr 2016, Wei Liu wrote:
> On Thu, Apr 07, 2016 at 07:45:26PM +0200, Roger Pau Monne wrote:
> > So libxl doesn't have to pass the build info around just to get the device
> > model used by the guest. This allows to simplify
> > libxl__device_nic_setdefault.
> > 
> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> > Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> > Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> I have some reservation on this approach. I would rather passing around
> a struct than accessing xenstore. The latter is much more expensive.

Sorry, my commit log wasn't very clear. The struct can't always be passed 
around, since it's only available at domain creation time, so we also need 
to xenstore way for hotplug.

Due to that, I think it's simpler to always use it, instead of having two 
different approaches depending on whether the build info struct is 
provided or not. TBH, this is only one xenstore read, so I would rather 
prefer to do it always this way in order to have simpler code.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.