Re: [Xen-devel] [PATCH v5 19/28] build_id: Provide ld-embedded build-ids

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 08.04.16 at 02:18, <konrad@xxxxxxxxxx> wrote:
>> > +  $(OBJCOPY) -I binary -O elf64-x86-64 -B i386:x86-64 \
>> > +          --rename-section=.data=.note.gnu.build-id -S $@.bin $@
>> 
>> Since you put the notes into .rodata anyway, why name the
>> section .note.*? Just name it .rodata.*, avoiding to mislead
>> others who also think that a section's name has much of a
>> meaning.
> 
> Way back last year:
> http://lists.xenproject.org/archives/html/xen-devel/2016-01/msg01264.html 

But that wasn't dealing with the EFI case at all back then.

> which is where the .note came about. I can put it all in .rodata
> and not have it for normal ELF builds if you would like.

It would, overall, look more consistent to me.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel