Re: [Xen-devel] [PATCH v7 17/24] build_id: Provide ld-embedded build-ids

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Mon, Apr 11, 2016 at 01:17:38PM +0100, Andrew Cooper wrote:
> On 10/04/16 22:14, Konrad Rzeszutek Wilk wrote:
> > diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile
> > index d210bb7..e8cd757 100644
> > --- a/xen/arch/x86/Makefile
> > +++ b/xen/arch/x86/Makefile
> > @@ -76,6 +76,12 @@ efi-y := $(shell if [ ! -r 
> > $(BASEDIR)/include/xen/compile.h -o \
> >                        -O $(BASEDIR)/include/xen/compile.h ]; then \
> >                           echo '$(TARGET).efi'; fi)
> >  
> > +ifneq ($(build_id_linker),)
> > +num_phdrs = --notes
> > +else
> > +num_phdrs =
> > +endif
> 
> This is hardly the number of phdrs.  It is whether to consider the notes
> phdr.

I made it:

s/num_phdrs/notes_phdrs/ ?

That OK?
> Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel