Re: [Xen-devel] [PATCH v8.1 09/27] x86/mm: Introduce modify_xen_mappings()

["Jan Beulich" <jbeulich@xxxxxxxx>]

>>> Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> 04/14/16 12:03 AM >>>
>-            /* If we are done with the L2E, check if it is now empty. */
>-            if ( (v != e) && (l1_table_offset(v) != 0) )
>+            /*
>+             * If we not destroying mappings, or are not done with the L2E,
>+             * skip the empty&free check.

It would have been really nice if you had added the missing "are" ...

>-        /* If we are done with the L3E, check if it is now empty. */
>-        if ( (v != e) && (l2_table_offset(v) + l1_table_offset(v) != 0) )
>+        /*
>+         * If we are not destroying mappings, or not done with the L3E,
>+         * skip the empty&free check.

... just like you did here.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel