Re: [Xen-devel] [for-4.7] x86/emulate: synchronize LOCKed instruction emulation

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 14/04/2016 06:56, Razvan Cojocaru wrote:
>
>>> --- a/xen/common/domain.c
>>> +++ b/xen/common/domain.c
>>> @@ -272,6 +272,8 @@ struct domain *domain_create(domid_t domid, unsigned 
>>> int domcr_flags,
>>  >
>>      >TRACE_1D(TRC_DOM0_DOM_ADD, d->domain_id);
>>  >
>>> +    percpu_rwlock_resource_init(&d->arch.emulate_lock, 
>>> emulate_locked_rwlock);
>> I cannot see how this would build on ARM.
> I'll add separate functions for ARM and x86, with a no-op for ARM.

Please move this line into arch_domain_create() arch/x86/domain.c

Strictly speaking, common code should never reference ->arch.  The bits
of ->arch which common code does touch should move up into common struct
domain.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel