Re: [Xen-devel] [PATCH v8.1 23/27] libxl: info: Display build_id of the hypervisor.

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Apr 13, 2016 at 06:02:04PM -0400, Konrad Rzeszutek Wilk wrote:
> If the hypervisor is built with we will display it.
> 
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> ---
> CC: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> CC: Wei Liu <wei.liu2@xxxxxxxxxx>

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

One nit below.

>  const libxl_version_info* libxl_get_version_info(libxl_ctx *ctx)
>  {
>      GC_INIT(ctx);
> @@ -5363,8 +5395,10 @@ const libxl_version_info* 
> libxl_get_version_info(libxl_ctx *ctx)
>          xen_capabilities_info_t xen_caps;
>          xen_platform_parameters_t p_parms;
>          xen_commandline_t xen_commandline;
> +        xen_build_id_t build_id;
>      } u;
>      long xen_version;
> +    int r;
>      libxl_version_info *info = &ctx->version_info;
>  
>      if (info->xen_version_extra != NULL)
> @@ -5397,6 +5431,17 @@ const libxl_version_info* 
> libxl_get_version_info(libxl_ctx *ctx)
>      xc_version(ctx->xch, XENVER_commandline, &u.xen_commandline);
>      info->commandline = libxl__strdup(NOGC, u.xen_commandline);
>  
> +    u.build_id.len = sizeof(u) - sizeof(u.build_id);
> +    r = libxl__xc_version_wrap(gc, info, &u.build_id);
> +    if (r == -ENOBUFS) {
> +            xen_build_id_t *build_id;
> +
> +            build_id = libxl__zalloc(gc, info->pagesize);
> +            build_id->len = info->pagesize - sizeof(*build_id);
> +            r = libxl__xc_version_wrap(gc, info, build_id);
> +            if (r)
> +                LOGEV(ERROR, r, "getting build_id");

Indentation of this block is wrong.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel