Re: [Xen-devel] [PATCH 2/3] libxc: adjust retry loop in xc_cpupool_removecpu()

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Juergen Gross writes ("[PATCH 2/3] libxc: adjust retry loop in 
xc_cpupool_removecpu()"):
> Commit 1ef6beea187b ("libxc: do some retries in xc_cpupool_removecpu()
> for EBUSY case") added a retry loop in xc_cpupool_removecpu() for the
> EBUSY case. As EBUSY was returned in multiple error situations the
> loop would have been executed in situations where a retry would not
> be successful. Additionally calling sleep(1) between the rerires is a
> bad idea when being called in a daemon.
> 
> The hypervisor has been changed to return different error values now.
> The retry added in above mentioned commit should be done in the
> EADDRINUSE case now. As the error condition should last only for a
> very short time, the sleep(1) call can be removed.
> 
> Requested-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>

Thanks.

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

I will follow up with further patches to improve the behaviour of xl.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel