Re: [Xen-devel] [PATCH v2 02/11] IOMMU: handle IOMMU mapping and unmapping failures

["Tian, Kevin" <kevin.tian@xxxxxxxxx>]

> From: Quan Xu
> Sent: Monday, April 18, 2016 10:00 PM
> 
> Now IOMMU mapping and unmapping failures are treated as a fatal to
> the domain (with the exception of the hardware domain).

'Now' is more about eixsting state, while it's actually what you want 
to change towards. Better directly say "Treat IOMMU mapping...".

> 
> If IOMMU mapping and unmapping failed, crash the domain (with the
> exception of the hardware domain) and propagate the error up to the
> call trees.
> 
> Signed-off-by: Quan Xu <quan.xu@xxxxxxxxx>
> 
> CC: Jan Beulich <jbeulich@xxxxxxxx>

Otherwise looks OK to me. 

Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel