Re: [Xen-devel] [PATCH v8.1 13/27] x86/xen_hello_world.xsplice: Test payload for patching 'xen_extra_version'.

["Jan Beulich" <jbeulich@xxxxxxxx>]

>>> Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> 04/14/16 12:03 AM >>>
>--- a/xen/arch/arm/Makefile
>+++ b/xen/arch/arm/Makefile
>@@ -57,6 +57,8 @@ ifeq ($(CONFIG_ARM_64),y)
        >ln -sf $(notdir $@)  ../../$(notdir $@).efi
 >endif
 >
>+tests:

I think this should be phony just like ...

>--- a/xen/arch/x86/Makefile
>+++ b/xen/arch/x86/Makefile
>@@ -76,6 +76,9 @@ $(TARGET): $(TARGET)-syms $(efi-y) boot/mkelf32
        >./boot/mkelf32 $(TARGET)-syms $(TARGET) 0x100000 \
        >`$(NM) -nr $(TARGET)-syms | head -n 1 | sed -e 's/^\([^ ]*\).*/0x\1/'`
 >
>+.PHONY: tests
>+tests:
>+      $(MAKE) -f $(BASEDIR)/Rules.mk -C test xsplice
 
 ... this one.

>--- /dev/null
>+++ b/xen/arch/x86/test/Makefile
>@@ -0,0 +1,44 @@
>+include $(XEN_ROOT)/Config.mk
>+
>+CODE_ADDR=$(shell nm --defined $(1) | grep $(2) | awk '{print "0x"$$1}')
>+CODE_SZ=$(shell nm --defined -S $(1) | grep $(2) | awk '{ print "0x"$$2}')
>+
>+.PHONY: default
>+
>+XSPLICE := xen_hello_world.xsplice
>+
>+default: xsplice
>+
>+install: xsplice
>+      $(INSTALL_DATA) $(XSPLICE) $(DESTDIR)$(DEBUG_DIR)/$(XSPLICE)
>+uninstall:
>+      rm -f $(DESTDIR)$(DEBUG_DIR)/$(XSPLICE)
>+
>+.PHONY: clean
>+clean::
>+      rm -f *.o .*.o.d $(XSPLICE) config.h
>+
>+#
>+# To compute these values we need the binary files: xen-syms
>+# and xen_hello_world_func.o to be already compiled.
>+#
>+# We can be assured that xen-syms is already built as we are
>+# the last entry in the build target.

Stale comment afaict.

>+.PHONY: xsplice
>+xsplice: config.h
>+      # Need to have these done in sequential order
>+      $(MAKE) -f $(BASEDIR)/Rules.mk xen_hello_world_func.o
>+      $(MAKE) -f $(BASEDIR)/Rules.mk xen_hello_world.o

Why do these two need doing in order? And why can't $(XSPLICE) not just depend
on its to object files, without needing explict make invocation to generate 
them?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel