Re: [Xen-devel] [PATCH for-4.7 1/5] build: make HOSTCC conditional on the value of clang

["Jan Beulich" <jbeulich@xxxxxxxx>]

>>> Roger Pau Monné <roger.pau@xxxxxxxxxx> 04/20/16 4:51 PM >>>
>On Sun, Apr 17, 2016 at 02:03:28PM -0600, Jan Beulich wrote:
>> >>> Roger Pau Monne <roger.pau@xxxxxxxxxx> 04/15/16 8:27 PM >>>
>> >@@ -50,8 +49,10 @@ DESTDIR     ?= /
>>  >clang ?= n
>>  >ifeq ($(clang),n)
>>  >gcc := y
>> >+HOSTCC = gcc
>>  >else
>>  >gcc := n
>> >+HOSTCC = clang
>>  >endif
>>  
>>  In particular I wonder what this means for cross builds, where someone may
>> have installed e.g. only a cross variant of clang.
>
>Right, I think this should be ?= instead of =, so if a user has HOSTCC set 
>in the build environment the build system doesn't overwrite it.
 >
>> That said, I'm not really opposed to the change (as it seems to be at least 
>> an
>> incremental improvement), I only wonder whether some more thought (and
>> change) is needed here.
>
>IMHO, I think using ?= should at least be more correct, or if anyone has a 
>better suggestion I'm happy to implement it.

Yes, that would at least eliminate some of my (admittedly vague) concerns.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel