Re: [Xen-devel] [PATCH] x86emul: special case far branch validation outside of long mode

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 11/03/16 16:01, Jan Beulich wrote:
> In that case (with the new value being held in, or now in one case cast
> to, a 32-bit variable) there's no need to go through the long mode part
> of the checks.
>
> Primarily this was meant to hopefully address Coverity ID 1355278, but
> since the change produces smaller code as well I think we should use it
> even if it doesn't help that (benign) warning.
>
> Also it's more in line with jmp_rel() for commit_far_branch() to do the
> _regs.eip update, so adjust that at once.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel