Re: [Xen-devel] [PATCH v2 04/11] grant_table: avoid unnecessary work during grant table unmapping

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 18.04.16 at 16:00, <quan.xu@xxxxxxxxx> wrote:
> --- a/xen/common/grant_table.c
> +++ b/xen/common/grant_table.c
> @@ -1366,8 +1366,9 @@ gnttab_unmap_grant_ref(
>       
>      return 0;
>  
> -fault:
> -    gnttab_flush_tlb(current->domain);
> + fault:
> +    if ( current->domain->is_shut_down )
> +        gnttab_flush_tlb(current->domain);

First of all: Is avoiding this really all that useful? You don't avoid
further work in any of the earlier patches. I.e. not the least for
consistency reasons I'd suggest dropping this patch.

And then, besides the condition being inverted as Kevin has already
pointed out, I think you mean ->is_shutting_down, not
->is_shut_down.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel