Re: [Xen-devel] [PATCH v2 11/11] vt-d: propagate error up to ME phantom function mapping and unmapping

["Xu, Quan" <quan.xu@xxxxxxxxx>]

On April 25, 2016 8:00 PM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
> >>> On 18.04.16 at 16:00, <quan.xu@xxxxxxxxx> wrote:
> > --- a/xen/drivers/passthrough/vtd/extern.h
> > +++ b/xen/drivers/passthrough/vtd/extern.h
> > @@ -91,7 +91,7 @@ int is_igd_vt_enabled_quirk(void);  void
> > platform_quirks_init(void);  void vtd_ops_preamble_quirk(struct iommu*
> > iommu);  void vtd_ops_postamble_quirk(struct iommu* iommu); -void
> > me_wifi_quirk(struct domain *domain, u8 bus, u8 devfn, int map);
> > +int me_wifi_quirk(struct domain *domain, u8 bus, u8 devfn, int map);
> 
> __must_check
>

Agreed, I will add it in next v3.

 
> > --- a/xen/drivers/passthrough/vtd/quirks.c
> > +++ b/xen/drivers/passthrough/vtd/quirks.c
> > @@ -332,10 +332,11 @@ void __init platform_quirks_init(void)
> >   * assigning Intel integrated wifi device to a guest.
> >   */
> >
> > -static void map_me_phantom_function(struct domain *domain, u32 dev,
> > int map)
> > +static int map_me_phantom_function(struct domain *domain, u32 dev,
> > +int map)
> 
> Again.
> 
Ditto.

Quan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel