[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH for-4.7] build/xen: fix assembler instruction tests

>>> On 27.04.16 at 16:42, <roger.pau@xxxxxxxxxx> wrote:
> The current test performed in order to check if the assembler supports
> certain instructions doesn't take into account the value of AFLAGS, which
> when using clang contains the option that disables the integrated assembler
> due to the lack of features.
> As a result of this, the current instruction tests were performed against 
> the
> integrated assembler, but then at build time the non-integrated assembler
> was used. If both have feature-parity, this is a non-issue, but we cannot
> assume this.
> Fix this by passing AFLAGS in the instruction test, and including the arch
> Rules.mk makefile after AFLAGS is set.
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Feels a little fragile at first, but looks okay, so:
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.