Re: [Xen-devel] [PATCH] xsplice: Don't perform multiple operations on same payload once work is scheduled.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 29.04.16 at 09:49, <konrad.wilk@xxxxxxxxxx> wrote:
> On Fri, Apr 29, 2016 at 01:35:08AM -0600, Jan Beulich wrote:
>> >>> On 29.04.16 at 03:52, <konrad@xxxxxxxxxx> wrote:
>> > --- a/xen/common/xsplice.c
>> > +++ b/xen/common/xsplice.c
>> > @@ -1363,6 +1363,9 @@ static int 
>> > xsplice_action(xen_sysctl_xsplice_action_t 
> *action)
>> >          return PTR_ERR(data);
>> >      }
>> >  
>> > +    if ( data->rc == -EAGAIN ) /* schedule_work has been called. */
>> > +        goto out;
>> 
>> And nothing else can set data->rc to this value, now or in the
> 
> Correct.
> 
>> future? Because if that's possible, you'd deny any further actions
>> on that payload.
> 
> Right. If the code does change and some of the underlaying code changes
> it to -EAGAIN we are in trouble.
> 
> Or rather, we can do something different (like the earlier patch that Andrew
> reviewed).

Yes, I think I'd prefer that one to be used.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel