Re: [Xen-devel] [PATCH] x86/shadow: account for ioreq server pages before complaining about not found mapping

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> Sent: 29 April 2016 09:14
> To: xen-devel
> Cc: Paul Durrant; Wei Liu; Tim (Xen.org)
> Subject: [PATCH] x86/shadow: account for ioreq server pages before
> complaining about not found mapping
> 
> prepare_ring_for_helper(), just like share_xen_page_with_guest(),
> takes a write reference on the page, and hence should similarly be
> accounted for when determining whether to log a complaint.
> 
> This requires using recursive locking for the ioreq server lock, as the
> offending invocation of sh_remove_all_mappings() is down the call stack
> from hvm_set_ioreq_server_state(). (While not strictly needed to be
> done in all other instances too, convert all of them for consistency.)

Do you have an example of a call stack? Is the recursion due to the 
domain_pause() being done with the ioreq server spinlock held?

  Paul

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel