[Xen-devel] drivers/net/xen-netfront.c bug report

[David Binderman <dcb314@xxxxxxxxxxx>]

Hello there,

drivers/net/xen-netfront.c:1567]: (style) Redundant condition: 
feature_split_evtchn. '!feature_split_evtchn || (feature_split_evtchn && err)' 
is equivalent to '!feature_split_evtchn || err'

Source code is

   if (!feature_split_evtchn || (feature_split_evtchn && err))

Suggest new code

   if (!feature_split_evtchn || err)

Also:

drivers/net/xen-netfront.c:2116]: (style) Variable 'target' is assigned a value 
that is never used.


Regards

David Binderman
                                          
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel