[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v10 04/24] xen-xsplice: Tool to manipulate xsplice payloads

> > +        /* The memset is done to catch errors. */
> > +        memset(info, 'A', sizeof(*info) * MAX_LEN);
> > +        memset(name, 'B', sizeof(*name * MAX_LEN * XEN_XSPLICE_NAME_SIZE));
> Did you mean to put the "* MAX_LEN * XEN_XSPLICE_NAME_SIZE" inside the
> sizeof()? Coverity thinks it's "suspicious", and I do to. :-)

I am kind of glad that this is the only thing Coverity is unhappy about
with this giant patchset.

But as you can see the comment: "The memset is done to catch errors" so
_obviously_ the odd placement of parenthesis was ah, part of that!


>  -George

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.