Re: [Xen-devel] [RFC PATCH 7/7] build: convert lock_profile to Kconfig

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Sun, May 01, 2016 at 11:10:46PM -0500, Doug Goldstein wrote:
> Convert the 'lock_profile' option to Kconfig as CONFIG_LOCK_PROFILE.
> 
> Signed-off-by: Doug Goldstein <cardoe@xxxxxxxxxx>
> ---
> CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> CC: Julien Grall <julien.grall@xxxxxxx>
> CC: Jan Beulich <jbeulich@xxxxxxxx>
> CC: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
>  INSTALL                    |  1 -
>  xen/Kconfig.debug          |  6 ++++++
>  xen/Rules.mk               |  2 --
>  xen/arch/arm/xen.lds.S     |  2 +-
>  xen/arch/x86/domain.c      |  2 +-
>  xen/arch/x86/xen.lds.S     |  2 +-
>  xen/common/keyhandler.c    |  2 +-
>  xen/common/spinlock.c      | 10 +++++-----
>  xen/common/sysctl.c        |  2 +-
>  xen/include/xen/spinlock.h |  4 ++--
>  10 files changed, 18 insertions(+), 15 deletions(-)
> 
> diff --git a/INSTALL b/INSTALL
> index 623887d..616a67a 100644
> --- a/INSTALL
> +++ b/INSTALL
> @@ -227,7 +227,6 @@ VGABIOS_REL_DATE="dd Mon yyyy"
>  
>  The following variables can be used to tweak some aspects of the
>  hypervisor build.
> -lock_profile=y
>  lto=y
>  
>  During tools build external repos will be cloned into the source tree.
> diff --git a/xen/Kconfig.debug b/xen/Kconfig.debug
> index 4727273..5b370e8 100644
> --- a/xen/Kconfig.debug
> +++ b/xen/Kconfig.debug
> @@ -28,6 +28,12 @@ config FRAME_POINTER
>         maybe slower, but it gives very useful debugging information
>         in case of any Xen bugs.
>  
> +config LOCK_PROFILE
> +     bool "Lock Profiiling"
> +     default n
> +     ---help---
> +       Lock Profiling

Would it make sense to also mention what tool one can use this with?

Perhaps:

"Lock profiling allows you to see how often locks are taken and blocked.
You can use serial console to print (and reset) using 'l' and 'L'
respectively, or the 'xenlockprof' tool.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel