Re: [Xen-devel] [PATCH v2 for-4.7 5/6] xen/xsplice: add ELFOSABI_FREEBSD as a supported OSABI for payloads

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 03/05/16 11:55, Roger Pau Monne wrote:
> The calling convention used by the FreeBSD ELF OSABI is exactly the same as
> the the one defined by System V, so payloads with a FreeBSD OSABI should be
> accepted by the xsplice machinery.
>
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> ---
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> Cc: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
> ---
>  xen/common/xsplice_elf.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/xen/common/xsplice_elf.c b/xen/common/xsplice_elf.c
> index 1e1f167..918a1bf 100644
> --- a/xen/common/xsplice_elf.c
> +++ b/xen/common/xsplice_elf.c
> @@ -397,7 +397,8 @@ static int xsplice_header_check(const struct xsplice_elf 
> *elf)
>      if ( hdr->e_version != EV_CURRENT ||
>           hdr->e_ident[EI_VERSION] != EV_CURRENT ||
>           hdr->e_ident[EI_ABIVERSION] != 0 ||
> -         hdr->e_ident[EI_OSABI] != ELFOSABI_NONE ||
> +         (hdr->e_ident[EI_OSABI] != ELFOSABI_NONE &&
> +         hdr->e_ident[EI_OSABI] != ELFOSABI_FREEBSD) ||

You should have an extra space of indentation here.

Other than that, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

>           hdr->e_type != ET_REL ||
>           hdr->e_phnum != 0 )
>      {


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel