[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 01/10] vt-d: fix the IOMMU flush issue

>>> On 04.05.16 at 14:09, <quan.xu@xxxxxxxxx> wrote:
> On May 04, 2016 9:26 AM, Tian, Kevin <kevin.tian@xxxxxxxxx> wrote:
>> > From: Xu, Quan
>> > Sent: Friday, April 29, 2016 5:25 PM
>> >  static void intel_iommu_iotlb_flush(struct domain *d, unsigned long
>> > gfn, unsigned int
>> > page_count)
>> could we remove "Intel_" prefix completely? You can rename this one to
>> iommu_flush_iotlb_page...
> Sure, I am ok.
> I wonder why to remove "Intel_" prefix.
> In this xen/drivers/passthrough/vtd/iommu.c file, most of functions are 
> beginning with "intel_" as intel specific.
> In xen/drivers/passthrough/iommu.c file, most of functions are beginning 
> with 'iommu_' as common part.

For non-static functions I'd suggest to keep the prefix (or use
vtd_ alternatively). For static functions there's no need to
disambiguate them, and hence an intel_ prefix is just mostly
useless baggage.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.