Re: [Xen-devel] [PATCH] x86/xstate: don't clobber or leak state when using XSAVES

[Shuai Ruan <shuai.ruan@xxxxxxxxxxxxxxx>]

On Fri, Apr 29, 2016 at 10:13:42AM +0100, Wei Liu wrote:
> On Fri, Apr 29, 2016 at 09:21:39AM +0800, Shuai Ruan wrote:
> > On Mon, Apr 25, 2016 at 01:07:54AM -0600, Jan Beulich wrote:
> > > Commit 4d27280572 ("x86/xsaves: fix overwriting between non-lazy/lazy
> > > xsaves") switched to always saving full state when using compacted
> > > format (which is the only one XSAVES allows). It didn't, however, also
> > > adjust the restore side: In order to save full state, we also need to
> > > make sure we always load full state, or else the subject vCPU's state
> > > would get clobbered by that of the vCPU which happened to last have in
> > > use the respective component(s).
> > > 
> > > Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> > This looks good to me.
> > 
> 
> Can we take this as an ack or a review tag?
> 
> Wei.
Yes.
Reviewed-by: Shuai Ruan <shuai.ruan@xxxxxxxxxxxxxxx>

Thanks
> 
> > Thanks 
> > 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel