Re: [Xen-devel] [PATCH V8] vm_event: Allow subscribing to write events for specific MSR-s

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 06.05.16 at 10:50, <rcojocaru@xxxxxxxxxxxxxxx> wrote:
> Changes since V7:
>  - Added Kevin Tian's ack.
>  - Moved memset()s from arch_monitor_init_domain() to
>    arch_monitor_cleanup_domain(), as suggested by Jan Beulich.
>  - Now using sizeof() instead of ARRAY_SIZE() in
>    monitor_bitmap_for_msr().
>  - d->arch.monitor_msr_bitmap->{low,hypervisor,high} are now
>    proper bitmaps (unsigned long arrays).

If they were, you'd have used DECLARE_BITMAP(). Please do so.

> +bool_t monitored_msr(struct domain *d, u32 msr)

const struct domain *

> +{
> +    unsigned long *bitmap;

const unsigned long *

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel