[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] IOMMU: don't BUG() on exotic hardware

On Fri, May 6, 2016 at 4:31 PM, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
> On Fri, May 06, 2016 at 08:24:28AM -0600, Jan Beulich wrote:
>> On x86, iommu_get_ops() BUG()s when running on non-Intel, non-AMD
>> hardware. While, with our current code, that's a correct prerequisite
>> assumption for IOMMU presence, this is wrong on systems without IOMMU.
>> Hence iommu_enabled (and alike) checks should be done prior to calling
>> that function, not after.
>> Also move iommu_suspend() next to iommu_resume() - it escapes me why
>> iommu_do_domctl() had got put between the two.
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> Release-acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Reviewed-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>


<<This happens because I choose it to happen!>> (Raistlin Majere)
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.