Re: [Xen-devel] [PATCH for 4.7 4/4] xen: adopt .deinit_pdata and improve timer handling

[Juergen Gross <jgross@xxxxxxxx>]

On 08/05/16 05:12, Meng Xu wrote:
> On Sat, May 7, 2016 at 5:19 PM, Meng Xu <mengxu@xxxxxxxxxxxxx> wrote:
>> On Tue, May 3, 2016 at 5:46 PM, Dario Faggioli
>> <dario.faggioli@xxxxxxxxxx> wrote:
>>>
>>> The scheduling hooks API is now used properly, and no
>>> initialization or de-initialization happen in
>>> alloc/free_pdata any longer.
>>>
>>> In fact, just like it is for Credit2, there is no real
>>> need for implementing alloc_pdata and free_pdata.
>>>
>>> This also made it possible to improve the replenishment
>>> timer handling logic, such that now the timer is always
>>> kept on one of the pCPU of the scheduler it's servicing.
>>> Before this commit, in fact, even if the pCPU where the
>>> timer happened to be initialized at creation time was
>>> moved to another cpupool, the timer stayed there,
>>> potentially inferfearing with the new scheduler of the
>>> pCPU itself.
>>>
>>> Signed-off-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
>>> --
>>
>> Reviewed-and-Tested-by: Meng Xu <mengxu@xxxxxxxxxxxxx>
> 
>>
>> ---Below is the testing scenarios---
>> echo "start test case 1..."
>> xl cpupool-list
>> xl cpupool-destroy cpupool-credit
>> xl cpupool-destroy cpupool-credit2
>> xl cpupool-destroy cpupool-rtds
>> xl cpupool-create ${cpupool_credit_file}
>> xl cpupool-create ${cpupool_credit2_file}
>> xl cpupool-create ${cpupool_rtds_file}
>> # Add cpus to each cpupool
>> echo "Add CPUs to each cpupool"
>> for ((i=0;i<5; i+=1));do
>> xl cpupool-cpu-remove Pool-0 ${i}
>> done
>> echo "xl cpupool-cpu-add cpupool-credit 0"
>> xl cpupool-cpu-add cpupool-credit 0
>> echo "xl cpupool-cpu-add cpupool-credit2 1,2"
>> xl cpupool-cpu-add cpupool-credit2 1
>> xl cpupool-cpu-add cpupool-credit2 2
>> echo "xl cpupool-cpu-add cpupool-rtds 3,4"
>> xl cpupool-cpu-add cpupool-rtds 3
>> xl cpupool-cpu-add cpupool-rtds 4
>> xl cpupool-list -c
>> xl cpupool-list
>> # Migrate vm1 among cpupools
>> echo "Migrate ${vm1_name} among cpupools"
>> xl cpupool-migrate ${vm1_name} cpupool-rtds
>> xl cpupool-migrate ${vm1_name} cpupool-credit2
>> xl cpupool-migrate ${vm1_name} cpupool-rtds
>> xl cpupool-migrate ${vm1_name} cpupool-credit
>> xl cpupool-migrate ${vm1_name} cpupool-rtds
>>
> 
> I forgot one thing in the previous email.
> When I tried to migrate Domain-0 from the Pool-0 (with rtds or credit
> scheduler) to another newly created pool, say cpupool-credit, it
> always fails.
> 
> This situation happens even when I boot into credit scheduler and try
> to migrate Domain-0 to another cpupool.
> 
> I'm wondering if Domain-0 can be migrated among cpupools?
> From the Xen wiki: http://wiki.xenproject.org/wiki/Cpupools_Howto, it
> seems Domain-0 can be migrated....

It can't. Domain-0 is always member of Pool-0.

I think at least an update of the xl man page would be a good idea.
I'll do a patch.


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel