Re: [Xen-devel] [PATCH v4 02/10] IOMMU: handle IOMMU mapping and unmapping failures

["Xu, Quan" <quan.xu@xxxxxxxxx>]

On May 10, 2016 4:03 PM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
> >>> On 10.05.16 at 09:53, <quan.xu@xxxxxxxxx> wrote:
> > +    rc = hd->platform_ops->unmap_page(d, gfn);
> > +
> > +    if ( unlikely(rc) )
> > +    {
> > +        if ( printk_ratelimit() )
> > +            printk(XENLOG_ERR
> > +                   "iommu_unmap_page: IOMMU unmapping gfn %#lx failed for
> dom%d.",
> > +                   gfn, d->domain_id);
> > +
> > +        if ( !is_hardware_domain(d) )
> > +            domain_crash(d);
> > +    }
> > +
> > +    return rc;
> 
> But please - as said - also avoid logging any message for already dying
> domains.
> 


Kept Kevin's opinion for later, I hope I have got your point as below:
...
+    rc = hd->platform_ops->unmap_page(d, gfn);
+
+    if ( unlikely(rc) )
+    {
+        if ( is_hardware_domain(d) )
+            if ( printk_ratelimit() )
+                printk(XENLOG_ERR
+                       "iommu_unmap_page: IOMMU unmapping gfn %#lx failed for 
dom%d.",
+                       gfn, d->domain_id);
+        else
+            domain_crash(d);
+    }
+
+    return rc;
...

Thanks for your patience.
Quan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel