[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH] xsplice: Prevent new symbols duplicating core symbols

When loading patches, the code prevents loading a patch containing a new
symbol that duplicates a symbol from another loaded patch. However, the
check should also prevent loading a new symbol that duplicates a symbol
from the core hypervisor.

Signed-off-by: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>

Wei, can you consider this for 4.7? Thanks

 xen/common/xsplice.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/xen/common/xsplice.c b/xen/common/xsplice.c
index c9fc53a..21b9ec0 100644
--- a/xen/common/xsplice.c
+++ b/xen/common/xsplice.c
@@ -748,7 +748,8 @@ static int build_symbol_table(struct payload *payload,
         if ( !found )
-            if ( xsplice_symbols_lookup_by_name(symtab[i].name) )
+            if ( symbols_lookup_by_name(symtab[i].name) ||
+                 xsplice_symbols_lookup_by_name(symtab[i].name) )
                 dprintk(XENLOG_ERR, XSPLICE "%s: duplicate new symbol: %s\n",
                         elf->name, symtab[i].name);

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.