[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH for-4.7] sched/rt: Fix memory leak in rt_init()



On Tue, May 10, 2016 at 9:38 AM, Andrew Cooper
<andrew.cooper3@xxxxxxxxxx> wrote:
> c/s 2656bc7b0 "xen: adopt .deinit_pdata and improve timer handling"
> introduced a error path into rt_init() which leaked prv if the
> allocation of prv->repl_timer failed.
>
> Introduce an error cleanup path.
>
> Spotted by Coverity.

I'm curious about this line. Does it mean that this is spotted by the
coverty code review or by some automatical testing/checking?

>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---

I'm sorry that I should have spot it out when I reviewed the code. :-(

Reviewed-by: Meng Xu <mengxu@xxxxxxxxxxxxx>


-----------
Meng Xu
PhD Student in Computer and Information Science
University of Pennsylvania
http://www.cis.upenn.edu/~mengxu/

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.