Re: [Xen-devel] [PATCH v1 4/7] page-alloc: Remove dependency on __LINE__ for release builds

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 06/05/16 16:48, Ross Lagerwall wrote:
> When using xsplice, use of __LINE__ can generate spurious changes in
> functions due to embedded line numbers.  For release builds, remove the
> use of these line numbers in BOOT_BUG_ON() and print the current text
> address instead.
>
> Signed-off-by: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>

I would just drop boot_bug() and BOOT_BUG_ON(), and replace them with
straight panic() calls.  It is only 3 uses in total.

The line numbers are really less helpful than a good description of the
reason for a panic.

~Andrew


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel