Re: [Xen-devel] [PATCH v1 6/7] acpi: Remove dependency on __LINE__ for release builds

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 06.05.16 at 17:48, <ross.lagerwall@xxxxxxxxxx> wrote:
> --- a/xen/drivers/acpi/utilities/utmisc.c
> +++ b/xen/drivers/acpi/utilities/utmisc.c
> @@ -134,6 +134,51 @@ const char *__init 
> acpi_ut_validate_exception(acpi_status status)
>  *
>  
> ******************************************************************************/
>  
> +#ifdef NDEBUG
> +void ACPI_INTERNAL_VAR_XFACE __init
> +acpi_ut_error(const char *module_name, void *addr, char *format, ...)
> +{
> +     va_list args;
> +
> +     acpi_os_printf("ACPI Error (%s-%p): ", module_name, addr);
> +
> +     va_start(args, format);
> +     acpi_os_vprintf(format, args);
> +     acpi_os_printf(" [%X]\n", ACPI_CA_VERSION);
> +     va_end(args);
> +}
> +
> +void ACPI_INTERNAL_VAR_XFACE __init
> +acpi_ut_warning(const char *module_name, void *addr, char *format, ...)
> +{
> +     va_list args;
> +
> +     acpi_os_printf("ACPI Warning (%s-%p): ", module_name, addr);
> +
> +     va_start(args, format);
> +     acpi_os_vprintf(format, args);
> +     acpi_os_printf(" [%X]\n", ACPI_CA_VERSION);
> +     va_end(args);
> +     va_end(args);
> +}
> +
> +void ACPI_INTERNAL_VAR_XFACE __init
> +acpi_ut_info(const char *module_name, void *addr, char *format, ...)
> +{
> +     va_list args;
> +
> +     /*
> +      * Removed module_name, line_number, and acpica version, not needed
> +      * for info output
> +      */
> +     acpi_os_printf("ACPI: ");
> +
> +     va_start(args, format);
> +     acpi_os_vprintf(format, args);
> +     acpi_os_printf("\n");
> +     va_end(args);
> +}
> +#else
>  void ACPI_INTERNAL_VAR_XFACE __init
>  acpi_ut_error(const char *module_name, u32 line_number, char *format, ...)
>  {

This is all __init code, runtime patching of which makes no sense
anyway (as it's gone by the time a patch can get applied), so
this patch seems pointless. And if it was nevertheless needed for
a reason I overlook right now, it's way too much redundant code
that gets added, i.e. proper abstraction to limit the impact would
be necessary.

Jan

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel