Re: [Xen-devel] [PATCH v4 08/10] vt-d/ept: propagate IOMMU Device-TLB flush error up to EPT update.

["Xu, Quan" <quan.xu@xxxxxxxxx>]

On Tuesday, May 10, 2016 5:10 PM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
> >>> On 06.05.16 at 10:54, <quan.xu@xxxxxxxxx> wrote:
> > --- a/xen/arch/x86/mm/p2m-ept.c
> > +++ b/xen/arch/x86/mm/p2m-ept.c
> > @@ -832,7 +832,8 @@ out:
> >           need_modify_vtd_table )
> >      {
> >          if ( iommu_hap_pt_share )
> > -            iommu_pte_flush(d, gfn, &ept_entry->epte, order, 
> > vtd_pte_present);
> > +            ret = iommu_pte_flush(d, gfn, &ept_entry->epte,
> > +                                  order, vtd_pte_present);
> >          else
> >          {
> >              if ( iommu_flags )
> 
> Looking at this in conjunction with patch 3, I can't see where "ret"
> would get consumed.
> 

Sorry, this 'ret' should be 'rc' here, as I removed  the pending

"
+    if ( !rc )
+        rc = ret;
+
"

from v4.


Quan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel