Re: [Xen-devel] [PATCH] xen: remove incorrect forward declaration

[Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>]

On 05/11/2016 03:05 PM, Juergen Gross wrote:
> On 11/05/16 15:07, Arnd Bergmann wrote:
> > A bugfix patch for the xen balloon driver introduced a forward
> > declaration for a static function that is conditionally compiled,
> > causing a warning if only the declaration but not the definition
> > are there:
> >
> > drivers/xen/balloon.c:154:13: error: 'release_memory_resource' declared 
> > 'static' but never defined [-Werror=unused-function]
> >   static void release_memory_resource(struct resource *resource);
> >
> > This removes the declaration again and instead moves the function
> > definition to the right place, before its first caller and inside
> > of the #ifdef protecting both.
> >
> > The patch that introduced the warning is marked for stable
> > backports, so if that gets applied to 4.4, so should this one.
> >
> > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> > Fixes: dfd74a1edfab ("xen/balloon: Fix crash when ballooning on x86 32 bit PAE")
> > Cc: stable@xxxxxxxxxxxxxxx
> So you've CC'ed Ross, who sent the very same patch just yesterday, but
> without the backport request.
Well it wasn't clear to me whether it should be the maintainer or the 
patch submitter who should request the backport and 
Documentation/SubmittingPatches is not clear about it. Regardless, the 
build fix should be backported to 4.4.
--
Ross Lagerwall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel