Re: [Xen-devel] [PATCH v3 5/6] build: convert perfc{, _arrays} to Kconfig

[Doug Goldstein <cardoe@xxxxxxxxxx>]

On 5/11/16 4:53 AM, Jan Beulich wrote:
>>>> On 10.05.16 at 23:05, <cardoe@xxxxxxxxxx> wrote:
>> Convert the 'perfc' and 'perfc_arrays' options to Kconfig as
>> CONFIG_PERF_COUNTERS and CONFIG_PERF_ARRAYS to minimize code changes.
> 
> I don't understand the "to minimize code changes" part.

Instead of calling the options "CONFIG_PERFC" and CONFIG_PERFC_ARRAYS"
as the originals would be called.

I do most of these Kconfig patches with sed and not by hand.

> 
>> @@ -12,18 +10,15 @@ lto           ?= n
>>  
>>  include $(XEN_ROOT)/Config.mk
>>  
>> -# Hardcoded configuration implications and dependencies.
>> -# Do this is a neater way if it becomes unwieldy.
>> -ifeq ($(perfc_arrays),y)
>> -perfc := y
>> -endif
>> -
>>  ifneq ($(origin kexec),undefined)
>>  $(error "You must use 'make menuconfig' to enable/disable kexec now.")
>>  endif
>>  ifneq ($(origin crash_debug),undefined)
>>  $(error "You must use 'make menuconfig' to enable/disable crash_debug now.")
>>  endif
>> +ifneq ($(origin perfc),undefined)
>> +$(error "You must use 'make menuconfig' to enable/disable perfc now.")
>> +endif
> 
> I'm pretty sure I've asked before: Why do you add something
> here for crash_debug and perfc, but not for debug, verbose,
> and frame_pointer?

I added the one you had mentioned. I didn't realize it was a uniform
statement. In the past (for other series) I've been told to drop those
statements for not common options.

As far as the debug one, I had that in patch 5 but passing the value in
but that was dropped.


> 
>> --- a/xen/arch/x86/x86_64/asm-offsets.c
>> +++ b/xen/arch/x86/x86_64/asm-offsets.c
>> @@ -151,7 +151,7 @@ void __dummy__(void)
>>      OFFSET(TRAPBOUNCE_eip, struct trap_bounce, eip);
>>      BLANK();
>>  
>> -#if PERF_COUNTERS
>> +#if CONFIG_PERF_COUNTERS
> 
> Same here - I'm pretty sure I've already asked for this to become
> #ifdef.
> 
> Jan
> 


-- 
Doug Goldstein

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel