[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 10/10] vt-d: propagate error up to ME phantom function mapping and unmapping

>>> On 12.05.16 at 07:16, <quan.xu@xxxxxxxxx> wrote:
> Taken together, there are 3 call trees to me_wifi_quirk():
>  1). 
> ...--me_wifi_quirk()--domain_context_mapping_one()--domain_context_mapping()--se
> tup_hwdom_device()
>                     There is no use in calling this function if an earlier 
> error occurred. The change can be more lightweight (the detailed change is 
> pending).
> 2).  me_wifi_quirk()--domain_context_unmap_one()--...
>                    As you mentioned,  while in the unmap case it should 
> probably stay as is, to fit the "best effort" theme. 
>                   Then I need to remove the  __must_check annotation  of 
> me_wifi_quirk().

This does not follow from the above. You again should propagate
the error in all cases (unless it would overwrite an earlier error - as
you're doing in various other places).


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.